Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP_MONITOR_DECODE environment variable not being honored (IDFGH-7482) #9052

Closed
bcr opened this issue May 28, 2022 · 1 comment
Closed

ESP_MONITOR_DECODE environment variable not being honored (IDFGH-7482) #9052

bcr opened this issue May 28, 2022 · 1 comment
Assignees
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally

Comments

@bcr
Copy link

bcr commented May 28, 2022

default=os.environ.get('ESP_MONITOR_DECODE') == 0

The problem seems to be that it's comparing the string from the environment variable with the integer zero, which will always be false.

Changing the integer zero to string zero '0' works in my environment.

-        default=os.environ.get('ESP_MONITOR_DECODE') == 0
+        default=os.environ.get('ESP_MONITOR_DECODE') == '0'
@espressif-bot espressif-bot added the Status: Opened Issue is new label May 28, 2022
@github-actions github-actions bot changed the title ESP_MONITOR_DECODE environment variable not being honored ESP_MONITOR_DECODE environment variable not being honored (IDFGH-7482) May 28, 2022
@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels May 30, 2022
@dobairoland
Copy link
Collaborator

Thank you @bcr for your report. It will be fixed soon.

@espressif-bot espressif-bot added Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: In Progress Work is in progress Resolution: NA Issue resolution is unavailable labels May 31, 2022
espressif-bot pushed a commit that referenced this issue Jun 8, 2022
espressif-bot pushed a commit that referenced this issue Jun 26, 2022
espressif-bot pushed a commit to espressif/esp-idf-monitor that referenced this issue Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

No branches or pull requests

3 participants