Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use "operator" as variable name (IDFGH-8000) #9510

Closed
higaski opened this issue Aug 6, 2022 · 1 comment
Closed

Don't use "operator" as variable name (IDFGH-8000) #9510

higaski opened this issue Aug 6, 2022 · 1 comment
Assignees
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally

Comments

@higaski
Copy link
Contributor

higaski commented Aug 6, 2022

The new MCPWM driver uses the C++ keyword operator as variable name.

typedef bool (*mcpwm_brake_event_cb_t)(mcpwm_oper_handle_t operator, const mcpwm_brake_event_data_t *edata, void *user_ctx);

Is this really necessary?
It's already really painful enough to include esp-idf C code into any kind of C++ file because of all the nested structs with designated initializers which isn't supported by C++ the same way.

@espressif-bot espressif-bot added the Status: Opened Issue is new label Aug 6, 2022
@github-actions github-actions bot changed the title Don't use "operator" as variable name Don't use "operator" as variable name (IDFGH-8000) Aug 6, 2022
@0xjakob 0xjakob self-assigned this Aug 16, 2022
@0xjakob
Copy link
Collaborator

0xjakob commented Aug 16, 2022

Hi @higaski, sorry for the inconvenience. Sometimes these things slip through because most developers don't use C++, but only C.

Is this really necessary?

I don't think so. We'll check this and probably change the variable name.

@espressif-bot espressif-bot assigned suda-morris and unassigned 0xjakob Aug 16, 2022
@espressif-bot espressif-bot added Status: In Progress Work is in progress Status: Reviewing Issue is being reviewed Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new Status: In Progress Work is in progress Status: Reviewing Issue is being reviewed Resolution: NA Issue resolution is unavailable labels Aug 16, 2022
espressif-bot pushed a commit that referenced this issue Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

No branches or pull requests

4 participants