Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit 4776f73c breaks SPI DMA #963

Closed
nickvanderstel opened this issue Sep 6, 2017 · 4 comments
Closed

Commit 4776f73c breaks SPI DMA #963

nickvanderstel opened this issue Sep 6, 2017 · 4 comments

Comments

@nickvanderstel
Copy link

Commit 4776f73 disables peripheral clocks by default, including the SPI DMA clock. This clock is not enabled when periph_module_enable() is called so SPI transfers with DMA enabled will always fail.

Is this DMA shared between all the SPI modules? Maybe this clock should be left running by default...
@jolivepetrus
Copy link

From the Lua RTOS team I can confirm this issue. Nothing in Lua RTOS works with SPI. We will fixed this by disabling DMA transfers in our SPI driver in a few minutes. Disabling DMA all works well.

jolivepetrus added a commit to whitecatboard/Lua-RTOS-ESP32 that referenced this issue Sep 7, 2017
@jolivepetrus
bugfix/spi don't works sincs esp-idf commit 4776f73c
2e83ab5 
DMA transfers have been disabled for now.

See espressif/esp-idf#963
@igrr
Copy link
Member

igrr commented Sep 7, 2017

Hi, the clock disabling commit broke SPI DMA, SDMMC, Ethernet, SDIO slave, and possibly the third-party CAN driver. We have merged the fix for this a couple of days ago, but due to some issues the master branch on Github has not been synchronized yet. Please use the attached patch set for now.

clock-enable-patches.zip

@jolivepetrus
Copy link

We can confirm that CAN is not affected.

@igrr igrr mentioned this issue Sep 7, 2017
Closed
@igrr
Copy link
Member

igrr commented Sep 7, 2017

Fixed in 51e8f43.

@igrr igrr closed this as completed Sep 7, 2017
jolivepetrus added a commit to whitecatboard/Lua-RTOS-ESP32 that referenced this issue Sep 7, 2017
@jolivepetrus
SPI DMA transfers reenabled after esp-idf espressif/esp-idf@51e8f43
cb1db56 
SPI DMA transfer disabled due to an esp-idf issue. See:

2e83ab5
espressif/esp-idf#963

After esp-idf espressif/esp-idf@51e8f43 DMA transfers work again in Lua RTOS SPI driver.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nickvanderstel @igrr @jolivepetrus