[v4.4.2] [Build] _Static_assert(sizeof(esp_chip_id_t) == 2, "esp_chip_id_t should be 16 bit"); (IDFGH-8479)

[chipweinberger]

IDF version.

v4.4.2-378-g9269a536ac

Operating System used.

macOS

How did you build your project?

Command line with idf.py

What is the expected behavior?

I'm using 4.4.2, top of branch, stock, it should build.

What is the actual behavior?

I should have brought up this issue a year ago.

On v4.3.x, v4.4.x, I've always had to comment out these 3 lines in esp_app_format.h because of a build error.

_Static_assert(sizeof(esp_chip_id_t) == 2, "esp_chip_id_t should be 16 bit");
_Static_assert(sizeof(esp_image_header_t) == 24, "binary image header should be 24 bytes");
_Static_assert(sizeof(esp_app_desc_t) == 256, "esp_app_desc_t should be 256 bytes");

I've never taken the time to figure out what causes it.

Steps to reproduce.

No special steps. Building with idf.py.

Build or installation Logs.

Log:

/Volumes/User/MBP-Google-Drive/jamcorder/firmware/esp-idf/components/bootloader_support/include/esp_app_format.h:24:15: error: expected constructor, destructor, or type conversion before '(' token
 _Static_assert(sizeof(esp_chip_id_t) == 2, "esp_chip_id_t should be 16 bit");
               ^
/Volumes/User/MBP-Google-Drive/jamcorder/firmware/esp-idf/components/bootloader_support/include/esp_app_format.h:91:15: error: expected constructor, destructor, or type conversion before '(' token
 _Static_assert(sizeof(esp_image_header_t) == 24, "binary image header should be 24 bytes");
               ^
/Volumes/User/MBP-Google-Drive/jamcorder/firmware/esp-idf/components/bootloader_support/include/esp_app_format.h:124:15: error: expected constructor, destructor, or type conversion before '(' token
 _Static_assert(sizeof(esp_app_desc_t) == 256, "esp_app_desc_t should be 256 bytes");
               ^
ninja: build stopped: subcommand failed.
ninja failed with exit code 1

[kayzen9]

@chipweinberger

Missing CPP guards in following header (?)

esp-idf/components/bootloader_support/include/esp_app_format.h

Line 24 in 9269a53

_Static_assert(sizeof(esp_chip_id_t) == 2, "esp_chip_id_t should be 16 bit");

For C++, it should be static_assert

[chipweinberger]

My code is all CPP, so that's a good theory.

Yes the capitalization is a bit weird.

[igrr]

Thanks for raising this issue, indeed the static asserts should be in an #ifndef __cplusplus block. Several other IDF header files seem to have the same issue.

(_Static_assert is correct syntax for C code until C23 standard; static_assert is correct for C++ and C>=23)

[chipweinberger]

Bumping. This is still broken on v4.4 branch (maybe master too)?

I'd open a PR, but I think I should get my other PR's in first, hah 🙂

[o-marshmallow]

Hi @chipweinberger ,

An internal PR is on-going to fix this issue, it will be backported to v4.4 as soon as it is merged

[chipweinberger]

appreciate the update! :)

[lamaanrana-eaton]

I am using IDF v4.4.0, also tried V4.4.5 but I am getting this error while building the code. I am not sure what to do here or how to get around it. it is only happening with one repo. I can compile all the projects from the examples in the ESP-IDF

[0xjakob]

I am using IDF v4.4.0, also tried V4.4.5 but I am getting this error while building the code. I am not sure what to do here or how to get around it. it is only happening with one repo. I can compile all the projects from the examples in the ESP-IDF

@lamaanrana-eaton Do you have a minimal reproducing example?