[Panic] also print to secondary USB Serial/JTAG Console (IDFGH-8578) #10027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chipweinberger
force-pushed
the
user/chip/panic-secondary-usb-serial-jtag
branch
from
cc07cf9
to
70b94b1
Compare
github-actions
bot
changed the title
igrr
requested changes
Oct 24, 2022
There was a problem hiding this comment.
Thanks for the PR @chipweinberger, it looks very useful! One minor request, looks good otherwise.
chipweinberger
force-pushed
the
user/chip/panic-secondary-usb-serial-jtag
branch
from
70b94b1
to
b2d1c34
Compare
espressif-bot
added
Status: Selected for Development
igrr
approved these changes
Oct 27, 2022
|
sha=b2d1c34a38fd2729294911c3b588ac689d4617f4 |
espressif-bot
added
Resolution: NA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During panic, we should also print to the secondary console.
Note: This was spun out into it's own PR from #9979