Fix CDT GCC parser to correctly parse C++ commands #1005
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously suggested parser command pattern: xtensa-esp32-elf-(g?cc)|([gc]\+\+)|(clang) was incorrect for compilation of c++ files, as it is expanded by Eclipse into or between: xtensa-esp32-elf-(g?cc) ([gc]\+\+) (clang) Additional grouping around existing pattern solves that issue, and helps Eclipse to correctly find ESP-IDF includes.
|
|
|
Oops, thank you for this @dziekon . Could you please click through to sign the CLA link above? Even though it's a small change we prefer if everyone signs the CLA. Then we can merge this fix ASAP. |
|
Done, and thanks for merging it. |
igrr
pushed a commit
that referenced
this pull request
Sep 21, 2017
Previously suggested parser command pattern: xtensa-esp32-elf-(g?cc)|([gc]\+\+)|(clang) was incorrect for compilation of c++ files, as it is expanded by Eclipse into or between: xtensa-esp32-elf-(g?cc) ([gc]\+\+) (clang) Additional grouping around existing pattern solves that issue, and helps Eclipse to correctly find ESP-IDF includes. Merges #1005
|
Cherry-picked as e822b37. |
0xFEEDC0DE64
pushed a commit
to 0xFEEDC0DE64/esp-idf
that referenced
this pull request
May 5, 2021
This fixes the compile error when we include SPI.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously suggested parser command pattern:
xtensa-esp32-elf-(g?cc)|([gc]++)|(clang)
was incorrect for compilation of c++ files, as it is expanded by Eclipse into or between:
xtensa-esp32-elf-(g?cc)
([gc]++)
(clang)
Additional grouping around existing pattern solves that issue, and helps Eclipse to correctly find ESP-IDF includes for C++ files.