[Heap Trace Standalone] fix terrible Leaks perf on large records by using doubly linked list (IDFGH-8690) #10133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❌ This PR is rejected in favor or a new PR: #10478 ❌
This augments: #10127 (Edit: this PR will need to be rebased onto #10141)
Leaks: The original implementation
memmove()
's the entire record buffer every time a record is freed. This is obviously terrible for perf.My ESP32-S3 was not useable after ~300 records in SPI ram.
With this change, I can keep
Heap Trace Standalone
enabled without a noticeable impact on perf, tested up to 2540 records!