Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPI fix DMA rxbuf size calculation (IDFGH-8793) #10224

Closed
wants to merge 1 commit into from

Conversation

tgotic
Copy link
Contributor

@tgotic tgotic commented Nov 22, 2022

(x+31)/8 doesn't round to 4 bytes (32 bits), e.g. (16+31)/8=47/8=5,
where ((x+31)/32)*4 does round to 4 bytes: (16+31)/32=(47/32)4=14=4

(x+31)/8 doesn't round to 4 bytes (32 bits), e.g. (16+31)/8=47/8=5,
where ((x+31)/32)*4 does round to 4 bytes: (16+31)/32=(47/32)*4=1*4=4
@espressif-bot espressif-bot added the Status: Opened Issue is new label Nov 22, 2022
@github-actions github-actions bot changed the title SPI fix DMA rxbuf size calculation SPI fix DMA rxbuf size calculation (IDFGH-8793) Nov 22, 2022
@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution.

@suda-morris
Copy link
Collaborator

sha=2a8d235938e41e34854f97953d3a0187822e131c

@suda-morris suda-morris added the PR-Sync-Merge Pull request sync as merge commit label Nov 23, 2022
@espressif-bot espressif-bot added Status: Reviewing Issue is being reviewed and removed Status: Opened Issue is new labels Nov 23, 2022
@espressif-bot espressif-bot added Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Reviewing Issue is being reviewed Resolution: NA Issue resolution is unavailable labels Dec 1, 2022
@suda-morris
Copy link
Collaborator

merged in the 36fcb4b

@suda-morris suda-morris closed this Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants