Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed mismatch in printf types (IDFGH-8883) #10304

Merged
merged 1 commit into from Dec 13, 2022
Merged

Fixed mismatch in printf types (IDFGH-8883) #10304

merged 1 commit into from Dec 13, 2022

Conversation

gregjesl
Copy link
Contributor

@gregjesl gregjesl commented Dec 3, 2022

Closes #10303

@github-actions github-actions bot changed the title Fixed mismatch in printf types Fixed mismatch in printf types (IDFGH-8883) Dec 3, 2022
@espressif-bot espressif-bot added the Status: Opened Issue is new label Dec 3, 2022
@KaeLL
Copy link
Contributor

KaeLL commented Dec 3, 2022

I believe the <inttypes.h> formats would be better.

@gregjesl
Copy link
Contributor Author

gregjesl commented Dec 3, 2022

@KaeLL Updates made 👍

igrr
igrr requested changes Dec 4, 2022
View reviewed changes
Copy link
Member

@igrr igrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @gregjesl!

Could you please also remove the following line in the same PR:

esp-idf/examples/get-started/hello_world/main/CMakeLists.txt

Line 4 in 7869f4e

target_compile_options(${COMPONENT_LIB} PRIVATE "-Wno-format")

and combine your changes into a single commit (using git rebase -i).

examples/get-started/hello_world/main/hello_world_main.c Outdated Show resolved Hide resolved
@gregjesl
Fixed mismatch in printf types
58d64f9 
Removed duplicate `l` in format

Updated print types

Updated CMake
@gregjesl
Copy link
Contributor Author

gregjesl commented Dec 4, 2022

@igrr Changes made. I updated a couple other print statements as well, let me know if I over-did it 😄

@igrr igrr added the PR-Sync-Merge Pull request sync as merge commit label Dec 5, 2022
@igrr
Copy link
Member

igrr commented Dec 5, 2022

sha=58d64f9a00dea44273004cfecc15f68008571ab3

@igrr igrr mentioned this pull request Dec 6, 2022
Closed
@igrr
Copy link
Member

igrr commented Dec 6, 2022

I updated a couple other print statements as well, let me know if I over-did it 😄

@gregjesl I actually had to revert the changes related to 8- and 16-bit types. This is because newlib-nano (CONFIG_NEWLIB_NANO_FORMAT option) doesn't support 8-bit-specific format specifier produced by PRIu8... (Our internal CI have caught this issue on C2, where CONFIG_NEWLIB_NANO_FORMAT is enabled by default and this example has started failing.)

@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels Dec 6, 2022
@espressif-bot espressif-bot merged commit 58d64f9 into espressif:master Dec 13, 2022
@espressif-bot espressif-bot added Resolution: Done Issue is done internally Status: Done Issue is done internally and removed Status: In Progress Work is in progress labels Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igrr igrr igrr approved these changes

Assignees

@igrr igrr

Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"hello_world" printf formats do not match input (IDFGH-8882)
4 participants
@gregjesl @KaeLL @igrr @espressif-bot