Widening 'ss' variable type in f_mkfs() #1031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Type of variable 'ss' should be widen from WORD to DWORD. The variable is passed to disk_ioctl by reference and get the value by assigning to (*uint32_t).
Send the reference to 'ss':
if (disk_ioctl(pdrv, GET_SECTOR_SIZE, &ss) != RES_OK) return FR_DISK_ERR;
Assign the value to 'ss' by reference:
in ff_wl_ioctl():
case GET_SECTOR_SIZE:
*((uint32_t *) buff) = wl_sector_size(wl_handle);
ff_sdmmc_ioctl():
case GET_SECTOR_SIZE:
*((uint32_t*) buff) = card->csd.sector_size;
Widening 'ss' variable type in ff.c
|
|
|
Thanks @jkearins for this fix. Something went funny in the branch (there's a random merge commit in there), so I've cherry-picked just this change into a new branch and submitted it to our review & merge queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of variable 'ss' should be widen from WORD to DWORD in function f_mkfs() defined in ff.c. The variable is passed to disk_ioctl() by reference and get the value by assigning to (*uint32_t).
Send the reference to 'ss':
if (disk_ioctl(pdrv, GET_SECTOR_SIZE, &ss) != RES_OK) return FR_DISK_ERR;
Assign the value to 'ss' by reference:
in ff_wl_ioctl():
case GET_SECTOR_SIZE:
*((uint32_t *) buff) = wl_sector_size(wl_handle);
ff_sdmmc_ioctl():
case GET_SECTOR_SIZE:
((uint32_t) buff) = card->csd.sector_size;