Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

component path relative to IDF (IDFGH-9429) #10797

Closed
wants to merge 1 commit into from

Conversation

ldab
Copy link
Contributor

@ldab ldab commented Feb 19, 2023

Change the component path to relative to the IDF as the build will fail if the example is moved from its folder.

@CLAassistant
Copy link

CLAassistant commented Feb 19, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ldab ldab marked this pull request as ready for review February 19, 2023 12:21
@espressif-bot espressif-bot added the Status: Opened Issue is new label Feb 19, 2023
@github-actions github-actions bot changed the title component path relative to IDF component path relative to IDF (IDFGH-9429) Feb 19, 2023
@igrr
Copy link
Member

igrr commented Feb 19, 2023

Thanks for the PR @ldab! We accept pull requests on master branch only, to ensure that once the issue is fixed, it is fixed for all subsequent versions. Once it is merged to master, we can backport the fix to the release branches.
Could you please rebase this PR and change the target branch to master?

Change the component path to relative to the IDF as the build will fail if the example is moved from its folder.

(cherry picked from commit 4011f5c)
@ldab ldab changed the base branch from release/v5.0 to master February 19, 2023 22:42
@rahult-github
Copy link
Collaborator

sha=4c2afac35502161ce473660c99e17feb013a378d

@rahult-github rahult-github added the PR-Sync-Merge Pull request sync as merge commit label Feb 20, 2023
@rahult-github
Copy link
Collaborator

sha=c88efb7fa8fdd469dbd1a1814d0500239f82e85c

@rahult-github rahult-github added the PR-Sync-Update Pull request sync fetch new changes label Feb 20, 2023
@espressif-bot espressif-bot added Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: Opened Issue is new Resolution: NA Issue resolution is unavailable labels Feb 28, 2023
@Alvin1Zhang
Copy link
Collaborator

Thanks for contribution again, changes have been merged with 60a7fe9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit PR-Sync-Update Pull request sync fetch new changes Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants