[GDBStub] kconfig gdbstub runtime should be separate bool (IDFGH-10309) #11569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
chipweinberger
force-pushed
the
user/chip/kconfig-gdbstub-separate-bool
branch
from
e4962ba
to
adfe341
Compare
chipweinberger
changed the title
chipweinberger
force-pushed
the
user/chip/kconfig-gdbstub-separate-bool
branch
from
adfe341
to
3991e9d
Compare
chipweinberger
force-pushed
the
user/chip/kconfig-gdbstub-separate-bool
branch
3 times, most recently
from
fd8d786
to
2d64d12
Compare
|
@Lapshin can you help take a look? |
Lapshin
reviewed
Jun 6, 2023
|
@Lapshin bump |
|
@chipweinberger , I still see open discussions for changes in this PR |
|
oh I missed that. will update. |
chipweinberger
force-pushed
the
user/chip/kconfig-gdbstub-separate-bool
branch
from
2d64d12
to
ab75781
Compare
|
@Lapshin updated. |
|
sha=ab757819aad60e0fb6a0e2d1b5c072cc71ab0520 |
|
@Lapshin any updates? would be great if you could ping some people to review this. |
espressif-bot
added
Status: Done
|
@chipweinberger , it was separated into two commits, the second one will be synced with GitHub repo soon |
|
merged a120ea8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #11568 (comment)
This is a runtime feature, not a panic feature.