hal/uart_ll.h: Fix compile with C++ deprecated volatile use (IDFGH-10892) #12093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These headers no longer work in C++ code with newer versions of GCC:
esp-idf/components/hal/esp32c6/include/hal/uart_ll.h: In function 'void uart_ll_ena_intr_mask(uart_dev_t*, uint32_t)':
esp-idf/components/hal/esp32c6/include/hal/uart_ll.h:229:21: error: compound assignment with 'volatile'-qualified left operand is deprecated [-Werror=volatile]
229 | hw->int_ena.val |= mask;
| ~~~~~~~~~~~~~~~~^~~~~~~
esp-idf/components/hal/esp32c6/include/hal/uart_ll.h: In function 'void uart_ll_disable_intr_mask(uart_dev_t*, uint32_t)':
esp-idf/components/hal/esp32c6/include/hal/uart_ll.h:242:21: error: compound assignment with 'volatile'-qualified left operand is deprecated [-Werror=volatile]
242 | hw->int_ena.val &= (~mask);
| ~~~~~~~~~~~~~~~~^~~~~~~~~~
|
|
github-actions
bot
changed the title
|
sha=62597d47fdcddcaf1e1b256f06e6d0c9f13a2e98 |
espressif-bot
added
Status: Done
espressif-bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
Merges #12093 fix(ll): remove FLAG_ATTR macro Such kind of operator overload will not work because C++ thinks such overload is ambiguous and it still prefer the built-in one which accepts and returns integer. Manually force type conversion seems to be unavoidable.
CommanderRedYT
pushed a commit
to CommanderRedYT/esp-idf
that referenced
this pull request
Sep 24, 2023
Merges espressif#12093 fix(ll): remove FLAG_ATTR macro Such kind of operator overload will not work because C++ thinks such overload is ambiguous and it still prefer the built-in one which accepts and returns integer. Manually force type conversion seems to be unavoidable.
movsb
pushed a commit
to movsb/esp-idf
that referenced
this pull request
Dec 1, 2023
Merges espressif#12093 fix(ll): remove FLAG_ATTR macro Such kind of operator overload will not work because C++ thinks such overload is ambiguous and it still prefer the built-in one which accepts and returns integer. Manually force type conversion seems to be unavoidable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These headers no longer work in C++ code with newer versions of GCC: