Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(console): drop the use of open_memstream() (IDFGH-11361) #12507

Closed

Conversation

alonbl
Copy link
Contributor

@alonbl alonbl commented Nov 1, 2023

the argtable3 provides string based output return, there is no need to go via stdio structures.

I found this usage during the review of #12493, we can implement this simpler, this code is the same as what runs in argparse3 when using open_memstream().

the argtable3 provides string based output return, there is no need to go via
stdio structures.

Signed-off-by: Alon Bar-Lev <alon.barlev@gmail.com>
Copy link

github-actions bot commented Nov 1, 2023

Messages
📖 Good Job! All checks are passing!

👋 Welcome alonbl, thank you for your first contribution to espressif/esp-idf project!

📘 Please check Contributions Guide for the contribution checklist, information regarding code and documentation style, testing and other topics.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for espressif/esp-idf project.

Pull request review and merge process you can expect

Espressif develops the ESP-IDF project in an internal repository (Gitlab). We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

  1. An internal issue has been created for the PR, we assign it to the relevant engineer
  2. They review the PR and either approve it or ask you for changes or clarifications
  3. Once the Github PR is approved, we synchronize it into our internal git repository
  4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing
    • At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
  5. If the change is approved and passes the tests it is merged into the master branch
  6. On next sync from the internal git repository merged change will appear in this public Github repository

Generated by 🚫 dangerJS against 270112f

@espressif-bot espressif-bot added the Status: Opened Issue is new label Nov 1, 2023
@github-actions github-actions bot changed the title change(console): drop the use of open_memstream() change(console): drop the use of open_memstream() (IDFGH-11361) Nov 1, 2023
@alonbl
Copy link
Contributor Author

alonbl commented Nov 17, 2023

Hi @0xjakob, can you please also review this one?

@igrr igrr added the PR-Sync-Merge Pull request sync as merge commit label Mar 27, 2024
@igrr
Copy link
Member

igrr commented Mar 27, 2024

sha=270112fdaf8c414364b73a9029206de76ae64c8f

@espressif-bot espressif-bot assigned igrr and unassigned 0xjakob Mar 27, 2024
@espressif-bot espressif-bot added Status: In Progress Work is in progress Status: Reviewing Issue is being reviewed Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: Opened Issue is new Status: In Progress Work is in progress Status: Reviewing Issue is being reviewed labels Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants