Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(freertos): fix broken critical section macros (IDFGH-11943) #13022

Closed
wants to merge 1 commit into from
Closed

fix(freertos): fix broken critical section macros (IDFGH-11943) #13022

wants to merge 1 commit into from

Conversation

andylinpersonal
Copy link
Contributor

@andylinpersonal andylinpersonal commented Jan 20, 2024 •
edited

Fix some rarely used portable macros related to critical section.

  1. Add the missing timeout parameter to xtensa port of portTRY_ENTER_CRITICAL_SAFE.
  2. Add the missing return value to RISC-V port of portEXIT_CRITICAL_SAFE and remove extra timeout parameter.

@andylinpersonal andylinpersonal changed the title fix(freertos): fix broken portable macros related to critical section fix(freertos): fix broken critical section macros Jan 20, 2024
@andylinpersonal andylinpersonal marked this pull request as ready for review January 20, 2024 20:17
@espressif-bot espressif-bot added the Status: Opened Issue is new label Jan 20, 2024
@github-actions github-actions bot changed the title fix(freertos): fix broken critical section macros fix(freertos): fix broken critical section macros (IDFGH-11943) Jan 20, 2024
@KonstantinKondrashov
Copy link
Collaborator

Hi @andylinpersonal! Thank you for your contribution, we will review it soon.

@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels Apr 3, 2024
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: In Progress Work is in progress labels Apr 17, 2024
igrr pushed a commit that referenced this pull request Apr 19, 2024
@andylinpersonal @sudeep-mohanty
fix(freertos): Fix broken portable macro portTRY_ENTER_CRITICAL_SAFE()
4f6deb9 
This commit fixes a bug where the portTRY_ENTER_CRITICAL_SAFE() for the
Xtensa and RISC-V FreeRTOS ports were broken as it did not correctly use
the timeout parameter.

Merges: #13022
@andylinpersonal
Copy link
Contributor Author

andylinpersonal commented Apr 23, 2024 •
edited

Merged in 5f19a87

espressif-bot pushed a commit that referenced this pull request Apr 23, 2024
@andylinpersonal @sudeep-mohanty
fix(freertos): Fix broken portable macro portTRY_ENTER_CRITICAL_SAFE()
6bcf473 
This commit fixes a bug where the portTRY_ENTER_CRITICAL_SAFE() for the
Xtensa and RISC-V FreeRTOS ports were broken as it did not correctly use
the timeout parameter.

Merges: #13022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sudeep-mohanty sudeep-mohanty

Labels
Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andylinpersonal @KonstantinKondrashov @Dazza0 @espressif-bot @sudeep-mohanty