Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(esp32s3): Add config value for RTC_XTAL_CAL_RETRY for S3 hardware variant (IDFGH-12051) #13114

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DaveLegg
Copy link

@DaveLegg DaveLegg commented Feb 5, 2024

Adding support for the RTC_XTAL_CAL_RETRY config setting to the ESP32S3.

This config setting is already supported on other chip variants. We have run into an issue recently with some production hardware where an additional retry was needed for the external crystal to be detected during a cold boot. Copying this behaviour from other chip variants has resolved the issue for us.

This change is such that it will not impact existing behaviour for users of the S3 variant, unless they specifically enable the config value

Copy link

github-actions bot commented Feb 5, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello DaveLegg, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against a8b4627

@espressif-bot espressif-bot added the Status: Opened Issue is new label Feb 5, 2024
@github-actions github-actions bot changed the title fix(esp32s3): Add config value for RTC_XTAL_CAL_RETRY for S3 hardware variant fix(esp32s3): Add config value for RTC_XTAL_CAL_RETRY for S3 hardware variant (IDFGH-12051) Feb 5, 2024
@songruo songruo added the PR-Sync-Merge Pull request sync as merge commit label Feb 18, 2024
@songruo
Copy link
Collaborator

songruo commented Feb 18, 2024

sha=a8b4627705ee5814bedf0065f51373dd46e297ba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Status: Opened Issue is new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants