Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use __builtin_unreachable in HAL_ASSERT no-assert mode (IDFGH-12202) #13256

Closed
wants to merge 1 commit into from

Conversation

haileys
Copy link

@haileys haileys commented Feb 25, 2024

This fixes a compile error when building with esp-clang:

esp-idf/components/hal/esp32/include/hal/mmu_ll.h:252:9: error: variable 'mmu_value' is used uninitialized whenever switch default is taken [-Werror,-Wsometimes-uninitialized]
        default:
        ^~~~~~~
esp-idf/components/hal/esp32/include/hal/mmu_ll.h:256:12: note: uninitialized use occurs here
    return mmu_value;
           ^~~~~~~~~
esp-idf/components/hal/esp32/include/hal/mmu_ll.h:242:23: note: initialize the variable 'mmu_value' to silence this warning
    uint32_t mmu_value;
                      ^
                       = 0

otherwise due to esp-idf using -Werror, we can get errors in code which
uses HAL_ASSERT if for example the compiler believes that a variable is
used uninitialised, or similar.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "use __builtin_unreachable in HAL_ASSERT no-assert mode":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello haileys, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against c3b7af6

@espressif-bot espressif-bot added the Status: Opened Issue is new label Feb 25, 2024
@github-actions github-actions bot changed the title Use __builtin_unreachable in HAL_ASSERT no-assert mode Use __builtin_unreachable in HAL_ASSERT no-assert mode (IDFGH-12202) Feb 25, 2024
@suda-morris
Copy link
Collaborator

sha=c3b7af6c3def8b0d5014c2389f5838b66705ee11

@suda-morris suda-morris added the PR-Sync-Merge Pull request sync as merge commit label Feb 26, 2024
@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels Feb 26, 2024
@haileys
Copy link
Author

haileys commented Feb 26, 2024

Hey sorry I didn't realise there was a CLA required. Regarding the patch, take it or leave it, but I'm just not that interested in reviewing a legal contract for this

@haileys haileys closed this Feb 26, 2024
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: In Progress Work is in progress labels Mar 6, 2024
espressif-bot pushed a commit that referenced this pull request Mar 7, 2024
otherwise due to esp-idf using -Werror, we can get errors in code which
uses HAL_ASSERT if for example the compiler believes that a variable is
used uninitialised, or similar.

Inspired by #13256
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants