Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allocate HTTP header space for async httpd_req_t objects (IDFGH-12445) #13462

Merged
merged 1 commit into from Apr 23, 2024

Conversation

tmiw
Copy link
Contributor

@tmiw tmiw commented Mar 25, 2024

This resolves bug #13430 by allocating a new copy of resp_hdrs when calling httpd_req_async_handler_begin(), thus preventing invalid access to memory from async tasks.

@CLAassistant
Copy link

CLAassistant commented Mar 25, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Mar 25, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello tmiw, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests via this public GitHub repository.

This GitHub project is public mirror of our internal git repository

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved, we synchronize it into our internal git repository.
4. In the internal git repository we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
5. If the change is approved and passes the tests it is merged into the default branch.
5. On next sync from the internal git repository merged change will appear in this public GitHub repository.

Generated by 🚫 dangerJS against f799e99

@espressif-bot espressif-bot added the Status: Opened Issue is new label Mar 25, 2024
@github-actions github-actions bot changed the title fix: Allocate HTTP header space for async httpd_req_t objects fix: Allocate HTTP header space for async httpd_req_t objects (IDFGH-12445) Mar 25, 2024
components/esp_http_server/src/httpd_txrx.c Outdated Show resolved Hide resolved
components/esp_http_server/src/httpd_txrx.c Outdated Show resolved Hide resolved
components/esp_http_server/src/httpd_txrx.c Outdated Show resolved Hide resolved
@mahavirj
Copy link
Member

Some minor comments, otherwise LGTM!

@tmiw
Copy link
Contributor Author

tmiw commented Mar 26, 2024

Some minor comments, otherwise LGTM!

Thanks for the feedback! I just pushed some changes to address the formatting/naming comments you had. Let me know if you end up seeing anything else.

@mahavirj
Copy link
Member

@tmiw Can you please squash the commits?

This resolves bug espressif#13430 by allocating a new copy of resp_hdrs
when calling httpd_req_async_handler_begin(), thus preventing
invalid access to memory from async tasks.
@tmiw
Copy link
Contributor Author

tmiw commented Mar 27, 2024

@tmiw Can you please squash the commits?

Done.

@mahavirj
Copy link
Member

sha=f799e9990952847be9d91b2051356fc8f2879676

@mahavirj mahavirj added the PR-Sync-Merge Pull request sync as merge commit label Mar 27, 2024
@espressif-bot espressif-bot added Status: In Progress Work is in progress and removed Status: Opened Issue is new labels Apr 1, 2024
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: NA Issue resolution is unavailable and removed Status: In Progress Work is in progress labels Apr 22, 2024
@espressif-bot espressif-bot merged commit d444ff5 into espressif:master Apr 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR-Sync-Merge Pull request sync as merge commit Resolution: NA Issue resolution is unavailable Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants