Add user pointers to avoid using global variables in callbacks (IDFGH-12601) #13599
+117
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation to propose this change is based on the callbacks used both by:
GAP: (esp_ble_gap_register_callback, esp_ble_gap_get_callback)
GATTS: (esp_ble_gatts_register_callback, esp_ble_gatts_get_callback)
The proposed solution is to add 2 new more entry points for each of the profiles:
GAP: (esp_ble_gap_register_ptr, esp_ble_gap_get_ptr)
GATTS: (esp_ble_gatts_register_ptr, esp_ble_gatts_get_ptr)
With these new entry points, the registered callbacks now have to ability to retrieve a pre-set user pointer, avoiding, in this way, the use of global variables, which is consolidated as a bad practice and should be avoided when possible. This problem yet has another weight in multi-core environments.