Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create temp config in the same dir as target #151

Merged
merged 1 commit into from
Dec 15, 2016
Merged

Conversation

rojer
Copy link
Contributor

@rojer rojer commented Dec 8, 2016

Fixes case where SDK and app are on different mounts

@projectgus
Copy link
Contributor

I'm a little lost by what this changes. From what I can see, "tmpname" is always created inside directory dirname, it's just a case of the file being called .tmpconfig.PID or sdkconfig.tmp.PID.

Am I missing some detail?

@rojer
Copy link
Contributor Author

rojer commented Dec 12, 2016

no, it's not just the name of the file, obviosuly.
dirname is actually empty and basename contains the path. this seems a bit weird, but i didn't dig deeper - see how 3 lines above newname is constructed from dirname and basename? i basically took that and added a temp suffix to it, that's all. as long as newname ends up correct, tmpname should too.

Fixes case where SDK and app are on different mounts
@rojer
Copy link
Contributor Author

rojer commented Dec 12, 2016

i made it more obvious by using newname directly.

@projectgus
Copy link
Contributor

Got it, thanks.

@igrr igrr merged commit 6380245 into espressif:master Dec 15, 2016
igrr pushed a commit that referenced this pull request Dec 15, 2016
Create temp config in the same dir as target

Fixes case where SDK and app are on different mounts

(In our usage of kconfig, dirname is the empty string & basename is the full path to sdkconfig)

Github pull request #151


See merge request !309
@rojer rojer deleted the kconf branch January 21, 2017 14:40
Andste82 added a commit to Andste82/esp-idf that referenced this pull request Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants