Fix hexdump comment and array size. See issue #1518. #1519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
DavidAntliff
force-pushed
the
issue-1518
branch
from
23856f7
to
7433a5c
Compare
DavidAntliff
force-pushed
the
issue-1518
branch
from
7433a5c
to
d472d30
Compare
|
Hi @DavidAntliff , Thanks for sending this. I've cherry-picked this into our internal review & merge queue. Once merged to the master branch (IDF v3.1-dev), we can backport the fix to the v3.0 release branch. Angus |
igrr
pushed a commit
that referenced
this pull request
Jan 23, 2018
|
Cherry-picked to master in 19f10c4. Will keep this open until the backport to the release/v3.0 branch has landed. |
|
Backported to v3.0 in e9a4eb5. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.