Add option to enable/disable ble service change registration #1673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @jedi7 , Sorry for the delay in getting back to you. For a new CONFIG_xxx option to be added to ESP-IDF, it will need a corresponding config item and description in the bt Kconfig file. Could you add one to this PR, please? @Yulong-espressif @Weijian-Espressif @TianHao-Espressif Can you please take a look and provide further review comments? Thanks. Angus |
Add option to enable/disable automatic registration of BLE Gattc service change notify. Which sends in parralel (with user message flow) commands to BLE server which sometime leads to GATT_BUSY. (BLE server is able to handle only one command at time) Solving Issue 1575
|
Hi @projectgus, I changed the commit and made reversed logic to make it more clear. |
jedi7
changed the title
Isl2017
approved these changes
Apr 10, 2018
|
Hi @jedi7 , I've rebased this branch and put it into our internal review & merge queue. Angus |
|
Cherry-picked as 801632d. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to enable/disable automatic registration of BLE Gattc
service change notify. Which sends in paralel
(with user message flow) commands to BLE server which
sometime leads to GATT_BUSY.
Solving Issue 1575