docs: refine some details on GPIOs and GP timers #1740
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On most microcontrollers I have worked with one can retrieve the current state of output GPIO pins. On ESP32 this is not the case if the pad is not explictly configured to route this information into the port by configuring it as input or i/o. Thus add a warning to the API documentation of gpio_get_level().
|
|
|
The table on the bottom of the CLA is broken (and a bit superfluous IMHO) btw. |
Replace c&p text with an actual description.
stefanct
changed the title
igrr
approved these changes
Mar 19, 2018
|
Thanks for the PR @stefanct, I've put these changes into the merge queue. |
igrr
pushed a commit
that referenced
this pull request
Mar 20, 2018
On most microcontrollers I have worked with one can retrieve the current state of output GPIO pins. On ESP32 this is not the case if the pad is not explictly configured to route this information into the port by configuring it as input or i/o. Thus add a warning to the API documentation of gpio_get_level(). Merges #1740
igrr
pushed a commit
that referenced
this pull request
Mar 20, 2018
Replace c&p text with an actual description. Merges #1740
igrr
pushed a commit
that referenced
this pull request
Mar 20, 2018
|
@stefanct Cherry-picked into master, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on my first ESP32 project (a bit-banging UART driver) I have noticed some points in the IDF documentation that could be improved. See individual commit messages for details please.