Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example 10_openssl_server should use TLSv1.2 instead of SSLv3 #214

Closed
wants to merge 1 commit into from
Closed

Example 10_openssl_server should use TLSv1.2 instead of SSLv3 #214

wants to merge 1 commit into from

Conversation

MalteJ
Copy link
Contributor

@MalteJ MalteJ commented Jan 10, 2017

For security reasons modern browsers, curl and openssl do not support the SSLv3 protocol anymore.
You should use TLSv1.2 instead.

Also there was a bug in the HTTP header.

@CLAassistant
Copy link

CLAassistant commented Jan 10, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@projectgus projectgus mentioned this pull request Feb 14, 2017
Closed
@projectgus projectgus added the Status: Pending blocked by some other factor label Feb 14, 2017
@projectgus
Copy link
Contributor

Thanks for sending this PR, sorry for the slow reply. I've rebased it against current master and submitted it to our internal review & merge queue.

igrr added a commit that referenced this pull request Feb 15, 2017
@igrr
Merge branch 'bugfix/openssl_server_example' into 'master'
34d0b00 
Example 10_openssl_server should use TLSv1.2 instead of SSLv3; fixed corrupted HTTP Header

* Merges github PR #214 #214
* Closes #333 #333

See merge request !501
@projectgus
Copy link
Contributor

Merged with a minor revert in 34d0b00:

After some internal discussion, the openssl_server example uses TLS_Server_Method() rather than TLS v1.2 for compatibility with older browsers. A comment has been added recommending TLS v1.2 where possible, for better security.

@projectgus projectgus closed this Feb 15, 2017
@igrr igrr removed the Status: Pending blocked by some other factor label Apr 12, 2017
@espressif-bot espressif-bot added Status: Opened Issue is new Status: In Progress Work is in progress Resolution: Done Issue is done internally Status: Done Issue is done internally and removed Status: Opened Issue is new Status: In Progress Work is in progress labels Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MalteJ @CLAassistant @projectgus @igrr @espressif-bot