Fix stackoverflow due to recursion in vfs_spiffs_readdir_r #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Is there any plan to merge this change into master or current running branch? |
|
Hello ritesh, |
|
I have tested the PR and to me it seems working. thanks |
|
Thanks for the PR @kostyan5, this should be merged soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current implementation of vfs_spiffs_readdir_r() has an issue with recursion. In the case where you have N consecutive files in /folder1/ and you're reading /folder2/, vfs_spiffs_readdir_r() gets recursively called N times. When N get sufficiently large (in my case around 35), stack overflows.
I updated vfs_spiffs_readdir_r() to use a do/while loop instead.
NOTE: I did not extensively test this beyond my specific use case.