Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade python-future required version to 0.15 #2428

Merged
merged 1 commit into from
Sep 24, 2018

Conversation

rojer
Copy link
Contributor

@rojer rojer commented Sep 18, 2018

It works fine and this way python-future from Ubuntu Bionic can be used.

@dobairoland
Copy link
Collaborator

Hi @rojer. Thanks for the PR. I was thinking about the downgrade but in my opinion it is not a good way to go. Probably we don't need to have anything special from 0.16 but it is hard to tell that whether "it would work fine" or not because there are Python scripts inside ESP-IDF which are not run by users/developers directly. 0.15 is three years old and 0.16 is two. I assume that the opposite (upgrade) will be necessary in the near future because of new versions of Python (3.7, 3.8) and deprecated older versions, like 2.6 (just see the recent changelog of the python-future repository). I emphasize that this is my own personal opinion.

If package provided by your OS is not sufficient then you still can do pip install --user -r $IDF_PATH/requirements.txt. You can even setup a virtual python environment and use that with ESP-IDF.

@rojer
Copy link
Contributor Author

rojer commented Sep 19, 2018

i know about PIP but it's always preferable to use distro's package manager if possible.
all other dependencies can be satisfied with package from the main repository, and this seemed like a small enough change, so i made it and seems to work ok in my day to day use.
i don't claim it to be comprehensive testing though. a point can also be made that 0.15.2 is good enough for such pyhton-heavy distro like ubuntu (they use python a lot for their stuff), so it should be ok.
do you have specific requirements that 0.16 satisfies and 0.15 does not?

@dobairoland
Copy link
Collaborator

Allright @rojer. After taking another look at the changelog and diff I agree with the downgrade. But please make it >=0.15.2. That version will be satisfied even by the Ubuntu 16.04 LTS package. Thanks!

It works fine and this way python-future from Ubuntu 16.04 and 18.04 can be used.
@rojer
Copy link
Contributor Author

rojer commented Sep 19, 2018

@dobairoland sure, done

@igrr igrr added the Status: Pending blocked by some other factor label Sep 19, 2018
@igrr igrr merged commit 9999720 into espressif:master Sep 24, 2018
@rojer rojer deleted the pyfuture branch September 29, 2018 10:01
rojer pushed a commit to cesanta/esp-idf that referenced this pull request Sep 29, 2018
I suspect the change made in espressif#2428 was stomped on unintentionally
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending blocked by some other factor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants