Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SSL mutual auth (IDFGH-1111) #2490

Closed
wants to merge 2 commits into from

Conversation

rbino
Copy link
Contributor

@rbino rbino commented Sep 28, 2018

This makes it possible to port esp-mqtt mutual auth support to the idf version.

Tested and working with the esp-mqtt mutual auth example.

@rbino
Copy link
Contributor Author

rbino commented Oct 4, 2018

Rebased on master with the new esp_ transport prefix

@rbino
Copy link
Contributor Author

rbino commented Oct 10, 2018

Rebased again to remove conflicts

@david-cermak
Copy link
Collaborator

Hi @rbino,

This looks really good and solves some recent requests from other customers!

We have taken you PR for internal review. I added all the needed bits from esp-mqtt
(including the recent PRs from you) to make it compilable/working together, also with the 'esp_' renaming (espressif/esp-mqtt#81 is no longer necessary)
Please note that it may take some time until reviewed and gone through the internal process and pipelines.

Thank you for your contribution and taking the time with all the rebasing/updating/renaming! It is really much appreciated!
David

@rbino
Copy link
Contributor Author

rbino commented Oct 17, 2018

Thanks, I will close the other PR since you already adapted the changes internally.

@mahavirj
Copy link
Member

mahavirj commented May 6, 2019

Closing, changes are already part of esp-tls component. Thanks.

@mahavirj mahavirj closed this May 6, 2019
@github-actions github-actions bot changed the title Add support for SSL mutual auth Add support for SSL mutual auth (IDFGH-1111) May 6, 2019
catalinio pushed a commit to catalinio/pycom-esp-idf that referenced this pull request Jun 28, 2019
david-cermak added a commit to espressif/esp-mqtt that referenced this pull request Dec 16, 2022
egnor pushed a commit to egnor/esp-mqtt that referenced this pull request Dec 23, 2022
egnor pushed a commit to egnor/esp-mqtt that referenced this pull request Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants