Updated routines in intr_alloc and cross_core to stay in IRAM #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nathanjel, There have been a couple of changes on the master branch recently that relate to this (including 4676d15). Can you please try with the latest master and see if these changes are still necessary? Thanks, Angus |
|
Hi, Currently on business trip. Will check on 24th Jan. |
|
Looks like the changes for disabling/enabling interrupts have been incorporated as part of another change already. I've cherry-picked the change that moves esp32_crosscore_int_send_yield() to IRAM and added it to our internal review queue. |
|
Thanks, this is perfect. |
|
Merged in 174c313 |
0xFEEDC0DE64
pushed a commit
to 0xFEEDC0DE64/esp-idf
that referenced
this pull request
May 5, 2021
* Add Sketch Update Library * Add MDNS Library * Add Arduino OTA Library * add missing library file * Add library files for Update * Add missing headers * fix ota command * Add espota binary * remove bad example * PlatformIO does not auto forward declare methods like Arduino Builder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got randomly a GuruMeditation with a IllegalInstruction while using SPI Flash commands, referring to line 164 of cache_utils.c - where spi_flash_enable_interrupts_caches_no_os() calls esp_intr_noniram_enable(). In theory the call is made after the spi_flash_restore_cache() call happens, but somehow it did not work well. Also I thought it might be better to have a function called from a IRAM function to also be in IRAM. After applying, the issues with spi_flash_* did not occur again.
There is also a fix to add another cross-core interrupt function to IRAM. It's called from an another IRAM function (vPortYieldOtherCore()) and I have encountered IllegalInstruction issues with this one as well.