-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake: Add ESP_PLATFORM to build environment. #2601
Conversation
… in the component directory.
Just realized that GitHub updates pull requests when new changes are added to the same branch, sorry about that. Both commits are however related to the same forum thread. |
…res changes in ESP-IDF from PR: espressif/esp-idf#2601
Just merged upstream/master into my fork to resolve the conflict. |
Hi @PerMalmberg , Thanks for submitting this, sorry for the extended delay in getting back to you. This looks good to me. The only sticking point is we are about to merge Generic CMake build support, which should make sharing CMake code between IDF and non-IDF CMake projects much easier. However, those changes will conflict with this PR. This PR is still useful though, because there may be situations where CMake libraries or other projects want to test at CMake runtime whether they are running inside IDF or inside a generic CMake project. Once we merge the Generic CMake support (next few days), I'll cherry-pick this PR onto our master branch and resolve the conflicts, and we can merge it that way. |
Now that the new CMake changes have been merged, could these changes please be cherry picked into master, @projectgus ? |
@PerMalmberg Yes, sorry for the hold-up. We got stuck discussing whether we should deprecate the |
@projectgus Have you decided on the variable name yet? |
After a long discussion, we're going to stick with ESP_PLATFORM for now. PR should be finally merged shortly... thanks for staying patient. |
And thank you for the update. Looking forward to be able to compile for both ESP and Linux again. |
(Handles case where idf.py is not being used.) Ref #2601
@projectgus I'm closing this since your commits resolves this PR. |
@PerMalmberg Thanks for that, and thanks for your patience while we worked through this change. |
As first discussed in this forum thread, the ESP_PLATFORM define is missing during configuration and build when building with CMake.