Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows install prerequisites script #264

Closed
wants to merge 5 commits into from
Closed

Update windows install prerequisites script #264

wants to merge 5 commits into from

Conversation

stefangotz
Copy link

The script for installing prerequisites on windows has he following shortcomings:

  • it does not work on a fresh msys installation
  • it fails to extend PATH so that it can use the python interpreter it installs
  • it incorrectly adds the toolchain to PATH
  • it does not gracefully handle a failed download of the toolchain zip file
  • it references an outdated toolchain zip file

…cessary because /opt does not exist in a fresh msys installation)
…a valid zip file to be able to handle partial downloads
… extended when reading esp32_toolchain.sh, not when creating it
@CLAassistant
Copy link

CLAassistant commented Jan 19, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@projectgus
Copy link
Contributor

Thanks @stefangotz , this looks good and handles most (all?) of the Windows bringup issues mentioned in #200.

Can you please click through and sign the repository's CLA?

@pathob
Copy link
Contributor

pathob commented Mar 8, 2017

@stefangotz ???

@stefangotz
Copy link
Author

As I've discussed with @projectgus via e-mail, I'm not comfortable signing the CLA. Sorry about that.

@stefangotz stefangotz closed this Mar 13, 2017
igrr pushed a commit that referenced this pull request Mar 28, 2017
…tructions.

Add notes about MSYS2 package mirrors & HTTP proxies for users in China.

Closes #260 #260
Closes #281 #281
Closes #200 #200
Closes #430 #430
Accomplishes similar goals to #264 #264
0xFEEDC0DE64 pushed a commit to 0xFEEDC0DE64/esp-idf that referenced this pull request May 5, 2021
Actually WiFiMulti is not working due some functions haven't equal comportment of ESP8266
Replace status == WL_DISCONNECTED => status != WL_CONNECTED
Replace scanComplete() => scanNetworks()

Maybe is more interesting, for keep the maximum compatibility, investigate why WL_DISCONNECTED and scanComplete() doesn't works in this case instead of just replace by this pull request.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants