Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected '$PATH' export order in docs (en) #2944

Closed
wants to merge 1 commit into from

Conversation

lenhart
Copy link
Contributor

@lenhart lenhart commented Jan 13, 2019

fixed order of '$PATH' export. xtensa-esp32-elf/bin was added at beginning of '$PATH' instead of end (which the docs later suggested to check w/ printenv

…nning of '$PATH' instead of end (which the docs later suggested to check w/ printenv
@CLAassistant
Copy link

CLAassistant commented Jan 13, 2019

CLA assistant check
All committers have signed the CLA.

@lenhart lenhart changed the title corrected '$PATH' export order corrected '$PATH' export order in docs (en) Jan 13, 2019
@lenhart
Copy link
Contributor Author

lenhart commented Jan 13, 2019

Also on these pages: You don't have to log off and on to apply PATH changes.
It suffices to do 'source ~/.profile'.
Would this be useful to change in the docs?
(Only downside: if you accidentally did multiple "export PATH=... " it won't reset the path variable.)

@projectgus
Copy link
Contributor

projectgus commented Jan 14, 2019

Thanks for correcting this, @lenhart.

Also on these pages: You don't have to log off and on to apply PATH changes.
It suffices to do 'source ~/.profile'.

Yes. If I remember correctly, we had some discussion about this and it was a conscious decision to simplify the guide. If you know how ~/.profile works then you'll do this anyhow regardless of whether it's in the docs. If you don't know how this works, it can easily become confusing when you run "source" in one terminal and then later you open a new terminal and ESP-IDF suddenly doesn't work in it. Rather than explain all the various implications, we chose to explain the one straightforward method.

@krzychb
Copy link
Collaborator

krzychb commented Jan 15, 2019

The changes LGTM. Thanks @lenhart!
I will get them to merge queue.

@igrr igrr closed this in 1332d3b Jan 30, 2019
@krzychb
Copy link
Collaborator

krzychb commented Jan 30, 2019

Hi @lenhart after some discussion the order of items in PATH have been standardized across documents in a separate MR. Thank you for initiating this update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants