Fix log tag comparison when using variable tags (such as non-literals). (IDFGH-897) #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidAntliff
added a commit
to DavidAntliff/esp32-poolmon
that referenced
this pull request
Jan 28, 2019
|
Looks like this was fixed on master in 750c8c0 - can we have this fix backported to 3.0.7 please? |
|
@DavidAntliff Thanks for being patient while someone got back to you. Our policy is only to backport high severity bugs, to reduce the amount of code churn and reduce the chance of regressions. Is updating to ESP-IDF v3.1.x a possibility for you? |
github-actions
bot
changed the title
igrr
pushed a commit
that referenced
this pull request
Apr 2, 2019
This is a fix for the esp_log_level_set function. The problem is when this function is called but NOT withe the same 'c' string constant that the LOG* calls used in each module, the cache check doesn't match, so the cached entry won't get updated. There's no point in optimizing this function anyway because it is only called rarely. Merges #1557 Closes #2996
|
@projectgus looks like @igrr may have already backported it to v3.0 (thank you) however I'm happy to start trialing v3.1 anyway. Thanks for getting back to me. I think this can be closed now. |
|
@DavidAntliff It seems like @igrr is more generous than I am. ;). That's great, I'm happy that this is a good outcome. Thanks again for being patient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting a log level by tag does not work when the tag is provided as a variable (rather than a literal string). This is because there is an incorrect equality performed in
esp_log_level_set(). A copy of the tag is made but the contents of this copy is not compared - instead the tag pointers are compared, which does not work for non-literal tags.Refer to this forum post: https://www.esp32.com/viewtopic.php?f=13&t=9004