Expand environment variables in gen_esp32part #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
projectgus
suggested changes
Feb 14, 2017
| @@ -163,7 +164,9 @@ def __init__(self): | |||
| def from_csv(cls, line): | |||
| """ Parse a line from the CSV """ | |||
| line_w_defaults = line + ",,,," # lazy way to support default fields | |||
| fields = [ f.strip() for f in line_w_defaults.split(",") ] | |||
| def expand_var(f): | |||
| return os.environ[f[1:]] if f.startswith("$") else f | |||
There was a problem hiding this comment.
Hi @rojer,
Sorry, this somehow fell off my radar for review.
I'm 100% OK with allowing environment variables in partition table definitions. I would prefer if we could allow mixing of variable references and plaintext in the same CSV field. Was hoping Python might have a function for this out of the box, but it looks like the best (simple) solution is a one-liner like in this SO answer: http://stackoverflow.com/a/30735354
Allows parametrizing partition table with (exported) make variables.
|
i thought about it too, didn't know about PTAL |
projectgus
approved these changes
Feb 14, 2017
|
Thanks @rojer. LGTM, have put into our internal review/merge queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows parametrizing partition table with (exported) make variables.