Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Server: Added ability to select core (IDFGH-774) #3190

Closed
wants to merge 1 commit into from
Closed

HTTP Server: Added ability to select core (IDFGH-774) #3190

wants to merge 1 commit into from

Conversation

gregjesl
Copy link
Contributor

Feature

The HTTP server task can now be pinned to a particular core.

Example Application

In our application one core is dedicated to driving a speaker. If the HTTP server runs on the same core as the task controlling the speaker, the speaker stutters when the device receives and HTTP request while operating the speaker. By moving the server to a different core, the stutter is eliminated.

Notes

The core is set to tskNO_AFFINITY in the default macro
This is a duplicate of #3137 due to a git merge issue.

The task that runs the HTTP server can now be pinned to a particular core by setting `core_id` in the HTTP server configuration.  By default, the core is set to `tskNO_AFFINITY`, meaning it can run on any core.
@gregjesl
Copy link
Contributor Author

@anurag-kar I've resubmitted the pull request from #3137

@github-actions github-actions bot changed the title HTTP Server: Added ability to select core HTTP Server: Added ability to select core (IDFGH-774) Mar 15, 2019
@anurag-kar
Copy link
Contributor

@gregjesl Thanks! This looks great. I'll take it through the internal review process now.

igrr pushed a commit that referenced this pull request Mar 26, 2019
The task that runs the HTTP server can now be pinned to a particular core by setting `core_id`
in the HTTP server configuration.  By default, the core is set to `tskNO_AFFINITY`, meaning
it can run on any core.

Merges #3190
@mahavirj
Copy link
Member

@gregjesl Change is now merged in master, have also fixed minor issue with esp_https_server.h header as well. Thanks.

@mahavirj mahavirj closed this Mar 26, 2019
@gregjesl
Copy link
Contributor Author

@mahavirj Great to hear, thanks!

0xFEEDC0DE64 pushed a commit to 0xFEEDC0DE64/esp-idf that referenced this pull request May 5, 2021
* Add support for WiFi long range mode

* Update WiFiGeneric.cpp
loganfin pushed a commit to Lumenaries/esp_http_server that referenced this pull request Apr 23, 2024
The task that runs the HTTP server can now be pinned to a particular core by setting `core_id`
in the HTTP server configuration.  By default, the core is set to `tskNO_AFFINITY`, meaning
it can run on any core.

Merges espressif/esp-idf#3190
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants