Fixed excess data coming from uninitialized variable in esp_efuse_get_pkg_ver (IDFGH-976) #3309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
|
Thanks, @Frosticles. It has picked into our internal repo. It will be merged with master ASAP. |
igrr
pushed a commit
that referenced
this pull request
Apr 16, 2019
Fixed esp_efuse_get_pkg_ver() function Closes: #3309 Closes: IDFGH-976
0xFEEDC0DE64
pushed a commit
to 0xFEEDC0DE64/esp-idf
that referenced
this pull request
May 5, 2021
* move scripts and tone down travis * Update and rename main.yml to push.yml * Create release.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to
esp_efuse_read_field_blobonly seems to set the 3 last bits ofpkg_ver. So the other uninitialised 29 bits inpkg_vergets returned.Before: 1073677826 (in binary)
111111111111110000011000000010, note the last 3 bits are correctAfter: 2