Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving flag into section for esp_event linker file (IDFGH-1007) #3335

Closed
wants to merge 1 commit into from

Conversation

tomseago
Copy link

If this flag is at the top level the linker generation script throws an error.

It appears that when this file was added an incorrect syntax was used. This pull request follows the syntax found for other components and allows the build of hello world to succeed. This fixes #3295

If this flag is at the top level the linker generation script throws an error
@CLAassistant
Copy link

CLAassistant commented Apr 19, 2019

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title Moving flag into section for esp_event linker file Moving flag into section for esp_event linker file (IDFGH-1007) Apr 19, 2019
@sieren
Copy link

sieren commented Apr 23, 2019

I've filed a PR for this earlier as well: #3322

Can you get away without the default section (as in mine)? I recall running into some issues without it.

@renzbagaporo
Copy link
Contributor

@tomseago @sieren

The top level flag check syntax was added recently. Unfortunately the recent pyparsing 2.4.0 might have introduced regression which affects our grammar, we've submitted an issue to the PyParsing Github issue tracker and waiting on a response.

re. the abscence of default section, an update is coming to use default mappings when no conditions match; removing this requirement. But for now having the final else block is more correct.

@igrr
Copy link
Member

igrr commented Jun 10, 2019

Closing as this got fixed in 2522268 (but it took another week for the fix to get synced to Github, sorry about that!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fail on v4.0-dev-311(linker script generation failed) when ESP32_WIFI_IRAM_OPT = n (IDFGH-958)
5 participants