Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPS OTA: Removed unnecessary free() (IDFGH-1209) #3513

Closed
wants to merge 1 commit into from
Closed

HTTPS OTA: Removed unnecessary free() (IDFGH-1209) #3513

wants to merge 1 commit into from

Conversation

gregjesl
Copy link
Contributor

Closes #3504

@gregjesl gregjesl mentioned this pull request May 21, 2019
Closed
@github-actions github-actions bot changed the title HTTPS OTA: Removed unnecessary free() HTTPS OTA: Removed unnecessary free() (IDFGH-1209) May 21, 2019
@mahavirj mahavirj requested a review from jitin17 May 22, 2019 06:24
@mahavirj
Copy link
Member

Good catch! This was regression introduced with recent refactoring from this component. @jitin17 Please help to check.

@jitin17
Copy link
Contributor

jitin17 commented May 22, 2019

@gregjesl Thanks for pointing this out. I will get this merged as soon as possible

igrr pushed a commit that referenced this pull request Jun 26, 2019
@gregjesl @espressif-bot
esp_https_ota: Removed unnecessary free()
7fbedb1 
Closes #3504

Merges #3513

Signed-off-by: Jitin George <jitin@espressif.com>
@mahavirj
Copy link
Member

@gregjesl Fixed with 7fbedb1 (bit modified version to take care of all possible scenarios). Also included in example level test to catch such regressions upfront.

@mahavirj mahavirj closed this Jun 27, 2019
trombik pushed a commit to trombik/esp-idf that referenced this pull request Aug 9, 2019
@gregjesl @trombik
esp_https_ota: Removed unnecessary free()
6ca2d11 
Closes espressif#3504

Merges espressif#3513

Signed-off-by: Jitin George <jitin@espressif.com>
espressif-bot pushed a commit that referenced this pull request Nov 19, 2019
@gregjesl @espressif-bot
esp_https_ota: Removed unnecessary free()
7db01c9 
Closes #3504

Merges #3513

Signed-off-by: Jitin George <jitin@espressif.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jitin17 jitin17 jitin17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stochastic OTA Behavior (IDFGH-1198)
3 participants
@gregjesl @mahavirj @jitin17