Clean-up the TCB at the right time. #359
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the ESP32 port the current statement about clean-up TCB does not apply:
Because it's not a tri-core port. What is actually useful is the ability to "release" an statically allocated TCB when a task is deleted. In order to do so,
portCLEAN_UP_TCB
can be used, but it needs to be called after all the accesses to the TCB are performed. In the current location, releasing the TCB causes a crash because the TCB is accessed by FreeRTOS several times afterwards. The proposed patch moves the call to the end and inside the check for a statically allocated TCB (where it makes sense).