malloc memory request size is updated (IDFGH-1490) #3757
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sizeof(CAP_SIG_NUM) will return only 4 bytes. However, we need 3*4 = 12 for three signals capture. So, CAP_SIG_NUM*sizeof(CAP_SIG_NUM) is valid for memory allocation. Otherwise, it will access out-of boundary memory.
|
|
github-actions
bot
changed the title
|
Thanks for your PR . We will fix this bug soon :-) |
igrr
pushed a commit
that referenced
this pull request
Jul 16, 2019
boarchuz
pushed a commit
to boarchuz/esp-idf
that referenced
this pull request
Jul 17, 2019
trombik
pushed a commit
to trombik/esp-idf
that referenced
this pull request
Aug 9, 2019
|
@rmshub Thanks for the contribution. This PR has already been merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sizeof(CAP_SIG_NUM) will return only 4 bytes. However, we need 34 = 12 for three signals capture. So, CAP_SIG_NUMsizeof(uint32_t) is valid for memory allocation. Otherwise, it will access out-of boundary memory.