Add aditional uint32_t object to ulp_insn_t to get the encoded instruction from bit-field structs (IDFGH-1492)
#3759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ruction from bit-field structs
|
|
github-actions
bot
changed the title
ulp_insn_t to get the encoded instruction from bit-field structsulp_insn_t to get the encoded instruction from bit-field structs (IDFGH-1492)
igrr
pushed a commit
that referenced
this pull request
Aug 21, 2019
Used to get the encoded instruction from bit-field structs. Merges #3759
|
@igrr Shall I close the PR considering that it has been merged ? |
|
@hex007 Thanks for the contribution, you could close this PR, it has been merged. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to quickly get the encoded instruction that can be assigned rather than needing
memcpyto assign.Current way of assignment looks bad :