Add export and install scripts for fish shell (IDFGH-2899) #4944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
changed the title
|
@eliabieri Thanks for your contribution. |
|
Nice Job! @eliabieri This PR really helps many fish users. We will merge is ASAP, it's already in our internal review list. |
|
Since this PR got closed, will it not be merged after all? Previously I was provided the information that the PR is already on a internal review list. |
|
@eliabieri The PR was cherry-picked as commit 0c1577f. Unfortunately Github doesn't recognize cherry-picked PRs as "merged"... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a fish shell version of the export.sh and install.sh scripts.
This will close #4459
Looking forward to your feedback.
Cheers