Make sure LD -L option is calculated correctly with complex SRCDIRS. #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile has specified SRCDIRS components that are not directly below Makefile folder level. For example, SRCDIRS = comp_a happy/comp_b /c/dev/comp_c Then the following are built: build/comp_a/libcomp_a.a build/comp_b/libcomp_b.a build/comp_c/libcomp_c.a But when LD is run the -L is calculated as follows -L build/comp_a -L build/happy/comp_b -L build//c/dev/comp_c This means comp_b and comp_c are not found by LD. With this change set -L is calculated correctly for comp_b and comp_c
|
|
|
Thanks @eyob-boye . This looks good to me, I've pushed it into our internal review & merge queue. |
igrr
pushed a commit
that referenced
this pull request
Apr 21, 2017
…ile has specified SRCDIRS components that are not directly below Makefile folder level. For example, SRCDIRS = comp_a happy/comp_b /c/dev/comp_c Then the following are built: build/comp_a/libcomp_a.a build/comp_b/libcomp_b.a build/comp_c/libcomp_c.a But when LD is run the -L is calculated as follows -L build/comp_a -L build/happy/comp_b -L build//c/dev/comp_c This means comp_b and comp_c are not found by LD. With this change set -L is calculated correctly for comp_b and comp_c Merges #504 #504
|
Cherry-picked as cdc7396, thanks! |
0xFEEDC0DE64
pushed a commit
to 0xFEEDC0DE64/esp-idf
that referenced
this pull request
May 5, 2021
* Create ISSUE_TEMPLATE.md * Add IDF component as example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the project Makefile has specified SRCDIRS components that are not directly below Makefile folder level, the LD -L option is not calculated correctly.
For example,
SRCDIRS = comp_a happy/comp_b /c/dev/comp_c
Then the following are built:
But when LD is run, the -L is calculated as follows
This means libcomp_b.a and libcomp_c.a are not found by LD. With this change set, -L is calculated correctly for comp_b and comp_c