Revisit: mbedtls port: Fix detection of EWOULDBLOCK/EAGAIN with non-blocking sockets #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
net_would_block, so the call to mbedtls_net_errno in mbedtls_net_recv and mbedtls_net_send will always get back 0. This change propagates the value returned by mbedtls_net_errno up through net_would_block, to allow the correct error value to be used and avoid a redundant call to mbedtls_net_errno.
projectgus
suggested changes
Apr 11, 2017
There was a problem hiding this comment.
This looks great, thank you. I like your fix.
This will also close #434 once merged.
Have requested one minor change but otherwise is great.
components/mbedtls/port/net.c
Outdated
| { | ||
| int error = mbedtls_net_errno(ctx->fd); | ||
|
|
||
| if ( errout ) *errout = error; |
There was a problem hiding this comment.
Minor style thing, but can you please put the assignment statement on a separate line inside curly braces. This in keeping with conditional style in the rest of the file.
…bits. Also, there are separate lengths for rx and tx (confusingly named rxlength and length... if rxlength is 0, length is used). The code checks the tx length for the rx, so it never validates rxlength.
projectgus
approved these changes
Apr 21, 2017
|
Thanks Michael. Sorry it took me so long to get back to this. I've squashed the mbedTLS commits and pushed them into our internal review & merge queue. I've also added the SPI master driver fix d92d57c. Angus |
igrr
pushed a commit
that referenced
this pull request
Apr 21, 2017
…ockets Since mbedtls_net_errno is reset by fcntl, it is reset after calling net_would_block, so the call to mbedtls_net_errno in mbedtls_net_recv and mbedtls_net_send will always get back 0. This change propagates the value returned by mbedtls_net_errno up through net_would_block, to allow the correct error value to be used and avoid a redundant call to mbedtls_net_errno. Merges PR #511 #511
igrr
pushed a commit
that referenced
this pull request
Apr 21, 2017
SPI transfer length is bits, not bytes, so the error should indicate bits. Also, there are separate lengths for rx and tx (confusingly named rxlength and length... if rxlength is 0, length is used). The code checks the tx length for the rx, so it never validates rxlength. Originally contributed as part of #511 #511
igrr
pushed a commit
that referenced
this pull request
Apr 21, 2017
mbedtls port: Fix detection of EWOULDBLOCK/EAGAIN with non-blocking sockets Since mbedtls_net_errno is reset by fcntl, it is reset after calling net_would_block, so the call to mbedtls_net_errno in mbedtls_net_recv and mbedtls_net_send will always get back 0. This change propagates the value returned by mbedtls_net_errno up through net_would_block, to allow the correct error value to be used and avoid a redundant call to mbedtls_net_errno. Merges PR #511 #511 See merge request !688
turmary
pushed a commit
to Seeed-Studio/Seeed_Arduino_mbedtls
that referenced
this pull request
Jan 22, 2020
…ockets Since mbedtls_net_errno is reset by fcntl, it is reset after calling net_would_block, so the call to mbedtls_net_errno in mbedtls_net_recv and mbedtls_net_send will always get back 0. This change propagates the value returned by mbedtls_net_errno up through net_would_block, to allow the correct error value to be used and avoid a redundant call to mbedtls_net_errno. Merges PR #511 espressif/esp-idf#511
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since mbedtls_net_errno is reset by fcntl, it is reset after calling
net_would_block, so the call to mbedtls_net_errno in mbedtls_net_recv
and mbedtls_net_send will always get back 0. This change propagates
the value returned by mbedtls_net_errno up through net_would_block,
to allow the correct error value to be used and avoid a redundant
call to mbedtls_net_errno.