Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify upper bits of ULP store instruction (IDFGH-3224) #5222

Closed
wants to merge 1 commit into from

Conversation

boarchuz
Copy link
Contributor

  • Improves consistency across references to the upper bits of a memory address written to by the ULP CP.

  • Documents [17:16] as the address register used.

@github-actions github-actions bot changed the title Clarify upper bits of ULP store instruction Clarify upper bits of ULP store instruction (IDFGH-3224) Apr 30, 2020
@Alvin1Zhang
Copy link
Collaborator

@boarchuz Thanks for your contribution.

@Alvin1Zhang Alvin1Zhang requested a review from igrr May 6, 2020 03:07
@ThymoNL
Copy link

ThymoNL commented Apr 13, 2021

I can confirm those 3 bits get set to the register address. @igrr any chance of this getting merged and maybe even getting it added to the technical reference manual?

@espressif-bot espressif-bot added the Status: In Progress Work is in progress label Apr 15, 2021
@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Done Issue is done internally and removed Status: In Progress Work is in progress labels Apr 26, 2021
espressif-bot pushed a commit that referenced this pull request Apr 27, 2021
@igrr
Copy link
Member

igrr commented May 5, 2021

Thanks again for the PR @boarchuz, it has been merged in 7e7c044.

@igrr igrr closed this May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants