Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vfs_fat_spiflash failed to mount / f_mkfs() #559

Closed
wants to merge 2 commits into from
Closed

Fix vfs_fat_spiflash failed to mount / f_mkfs() #559

wants to merge 2 commits into from

Conversation

nineisk
Copy link
Contributor

@nineisk nineisk commented May 2, 2017

No description provided.

@igrr igrr added the Status: Pending blocked by some other factor label May 3, 2017
@igrr
Copy link
Member

igrr commented May 3, 2017

Thanks for the fix. Will merge this soon.
FM_SFD usage was a pretty late change, and while testing I had the filesystem created already.

igrr added a commit that referenced this pull request May 5, 2017
@igrr
Merge branch 'bugfix/spiflash_fatfs_fixes_and_tests' into 'master'
33b8b78 
FATFS fixes and tests

This MR includes a set of fixes related to FATFS, SDMMC, and wear levelling:

- `esp_vfs_fat_spiflash_mount` uses `FM_SFD` flag when creating the partition. The volume layout (given in `VolToPart` variable) was not compatible with SFD mode, so mkfs was failing. This fixes the volume layout to use "autodetect" for both volumes. Merges #559.

- fix `prepend_drive_to_path`function, which didn't prepend drive to path (while consuming 2k of stack space)

- fix stack overflow in vfs_fat_link function which allocated two 4kbyte `FIL` structures on the stack

- fix support for having two FATFS instances (in flash and SD) mounted at the same time

- unit tests written for FATFS on SDMMC are made common between SDMMC and WL implementations; FATFS unit tests on WL will run during CI

- fix inconsistent definition of PATH_MAX and ARG_MAX (TW12207, TW12104, #289)

See merge request !732
@igrr
Copy link
Member

igrr commented May 5, 2017

Thanks for the PR! Cherry-picked in b65779e.

@igrr igrr closed this May 5, 2017
@igrr igrr removed the Status: Pending blocked by some other factor label May 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nineisk @igrr