Make gen_esp32part.py compatible with both python2.7 and python3. #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks for sending this, @dmopalmer . FWIW, this change looks good to me (I'm the original gen_esp32part.py author.) I'd been meaning to do something like this for gen_esp32part.py and the other IDF Python tools for a while. I expect this change will mean everything works fine with Python 3 in ESP32 Arduino. esptool.py is tested working with Python 2 & 3 already. |
|
Oops, when I replied before I thought this PR was on the arduino repo not the IDF one. Have cherry-picked this into our review & merge queue, with a few additional tweaks. |
igrr
pushed a commit
that referenced
this pull request
May 16, 2017
|
Merged in beffcd6, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into the issue of espressif/arduino-esp32#236
This is an step forward to make the toolchain compatible with Python3. It includes both a comparison issue and unicode/str/bytes issues.
This has been tested to the extent that 'make flash' of hello_world.c runs under both python2.7 and python 3.6.1 under OSX, and I don't see any reason why it shouldn't work under linux.
The test that I have not done is: under Windows, does the binary output to stdout work properly (and did it before)?
In the binary case, I use 'wb' as the mode for files, and use stdout.buffer instead of stdout as the writeable object . So what was windows doing when it tried to write a 0x0a (which is the byte for newline)? Did it add an 0x0d byte (to make it look like '\r\n')?