Print the name of the task that hit the stack watchpoint #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may be enough to troubleshoot (increase stack size).
igrr
reviewed
May 16, 2017
| @@ -212,7 +212,10 @@ void panicHandler(XtExcFrame *frame) | |||
| //debugcause if the cause is watchdog 1 and clearing it if it's watchdog 0. | |||
| if (debugRsn&(1<<8)) { | |||
| #if CONFIG_FREERTOS_WATCHPOINT_END_OF_STACK | |||
| panicPutStr("Stack canary watchpoint triggered "); | |||
| const char *name = pcTaskGetTaskName(xTaskGetCurrentTaskHandleForCPU(core_id)); | |||
There was a problem hiding this comment.
This pointer will likely be in cached region of memory. Would it make sense to sanity-check it before trying to print it? I.e. something like
if (spi_flash_cache_enabled() || !((uint32_t) name >= SOC_DROM_LOW && (uint32_t) name < SOC_DROM_HIGH))
There was a problem hiding this comment.
but task name is a member of the current TCB, so, is it actually possible for it to be not in RAM?
There was a problem hiding this comment.
task name provided by the user is copied into this field
|
Thanks @rojer. I've cherry-picked this into our internal review & merge queue. |
igrr
pushed a commit
that referenced
this pull request
May 19, 2017
This may be enough to troubleshoot (increase stack size). Merges #607
|
Cherry-picked as 3ac3a78, thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may be enough to troubleshoot (increase stack size).