tcpip_adapter_dhcpc_stop() contains a bug which prevents setting static IP for Ethernet (IDFGH-3521)

[hwmaier]

Without this fix DHCP cannot be stopped for Ethernet and subsequent settings of static IP addresses fail because DHCP is still running.

[benpeoples]

Poking this thread.

Easy one-liner, works great, fixes a core functionality bug. =)

[hwmaier]

Not sure why this fix has not been yet pulled into the main branch.

[benpeoples]

Probably bigger fish to fry at the moment... I get the feeling the ethernet folks are a pretty small population.

[projectgus]

Hi @hwmaier & others,

Sorry this was left sitting for such a long time. Fix is now cherry-picked, and queued for review & merge.

Angus

[projectgus]

Cherry-picked as 58ba8a2.

[JeanCarloEM]

This correction, for some reason, does not appear as applied to the dhcp server (dhcpS), only for dhcp client (dhcpC). So, I manually applied the fix to the equivalent dhcp server (dhcpS) functions, and it worked.

I suggest that such a correction be applied to dhcpS as well.

[david-cermak]

@JeanCarloEM It might get tricky to run DHCP server using tcpip_adapter without a modification of SDK. It is recommended to use esp-netif for IDF versions >= v4.1. Please refer to this post on setting up a DHCP server on ethernet interface #4086 (comment)