New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tcpip_adapter_dhcpc_stop() contains a bug which prevents setting static IP for Ethernet #657

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@hwmaier
Contributor

hwmaier commented May 31, 2017

Without this fix DHCP cannot be stopped for Ethernet and subsequent settings of static IP addresses fail because DHCP is still running.

@benpeoples

This comment has been minimized.

Show comment
Hide comment
@benpeoples

benpeoples Aug 19, 2017

Poking this thread.

Easy one-liner, works great, fixes a core functionality bug. =)

benpeoples commented Aug 19, 2017

Poking this thread.

Easy one-liner, works great, fixes a core functionality bug. =)

@hwmaier

This comment has been minimized.

Show comment
Hide comment
@hwmaier

hwmaier Aug 20, 2017

Contributor

Not sure why this fix has not been yet pulled into the main branch.

Contributor

hwmaier commented Aug 20, 2017

Not sure why this fix has not been yet pulled into the main branch.

@benpeoples

This comment has been minimized.

Show comment
Hide comment
@benpeoples

benpeoples Aug 20, 2017

Probably bigger fish to fry at the moment... I get the feeling the ethernet folks are a pretty small population.

benpeoples commented Aug 20, 2017

Probably bigger fish to fry at the moment... I get the feeling the ethernet folks are a pretty small population.

@projectgus

This comment has been minimized.

Show comment
Hide comment
@projectgus

projectgus Aug 30, 2017

Member

Hi @hwmaier & others,

Sorry this was left sitting for such a long time. Fix is now cherry-picked, and queued for review & merge.

Angus

Member

projectgus commented Aug 30, 2017

Hi @hwmaier & others,

Sorry this was left sitting for such a long time. Fix is now cherry-picked, and queued for review & merge.

Angus

igrr pushed a commit that referenced this pull request Sep 8, 2017

igrr added a commit that referenced this pull request Sep 8, 2017

Merge branch 'bugfix/tcpip_adapter_ethernet' into 'master'
tcpip_adapter: Fix bug which prevents setting a static IP address for Ethernet interface (github #657)

See merge request !1178
@projectgus

This comment has been minimized.

Show comment
Hide comment
@projectgus

projectgus Sep 20, 2017

Member

Cherry-picked as 58ba8a2.

Member

projectgus commented Sep 20, 2017

Cherry-picked as 58ba8a2.

@projectgus projectgus closed this Sep 20, 2017

@igrr igrr removed the merge pending label Nov 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment