GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Without this fix DHCP cannot be stopped for Ethernet and subsequent settings of static IP addresses fail because DHCP is still running.
tcpip_adapter_dhcpc_stop() contains a bug which prevents setting a st…
…atic IP address for Ethernet interface
Removed now obsolete comments
Poking this thread.
Easy one-liner, works great, fixes a core functionality bug. =)
Not sure why this fix has not been yet pulled into the main branch.
Probably bigger fish to fry at the moment... I get the feeling the ethernet folks are a pretty small population.
Hi @hwmaier & others,
Sorry this was left sitting for such a long time. Fix is now cherry-picked, and queued for review & merge.
tcpip_adapter: Fix bug which prevents setting a static IP address for…
… Ethernet interface
Merge branch 'bugfix/tcpip_adapter_ethernet' into 'master'
tcpip_adapter: Fix bug which prevents setting a static IP address for Ethernet interface (github #657)
See merge request !1178
Cherry-picked as 58ba8a2.