Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a KSZ8851SNL SPI Ethernet driver (IDFGH-4837) #6636

Closed
wants to merge 3 commits into from
Closed

Add a KSZ8851SNL SPI Ethernet driver (IDFGH-4837) #6636

wants to merge 3 commits into from

Conversation

b1ackviking
Copy link
Contributor

Implement the PHY and MAC layers in the driver similar to the W5500 driver.

Update Kconfig, CMakeLists.txt, and component.mk to incorporate the changes.

Resolves: #6542

Implement the PHY and MAC layers in the driver similar to
the W5500 driver.

Update Kconfig, CMakeLists.txt, and component.mk to incorporate
the changes.

Resolves: #6542
@CLAassistant
Copy link

CLAassistant commented Mar 1, 2021

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title Add a KSZ8851SNL SPI Ethernet driver Add a KSZ8851SNL SPI Ethernet driver (IDFGH-4837) Mar 1, 2021
@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution.

@Alvin1Zhang
Copy link
Collaborator

Thanks for your contribution. We have purchased the hardware but not received now, will update once we have any updates. Thanks.

@b1ackviking
Copy link
Contributor Author

Hello @Alvin1Zhang
Are there any updates? Have you managed to test the driver?

@Alvin1Zhang
Copy link
Collaborator

@b1ackviking Thanks for your contribution, and sorry for late reply, we are testing now, will share updates later.

@b1ackviking
Copy link
Contributor Author

@Alvin1Zhang Thanks. I hope it won't take much time. Please keep me updated.

Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for posting this PR. It has been internally approved and will be merged soon. Some minor changes will be applied in a separate commit, especially using the global error handling, introduced in 6792024 (which happened after your PR)

Sorry for the slow turnaround.

@espressif-bot espressif-bot added Status: Done Issue is done internally Resolution: Done Issue is done internally labels Apr 23, 2021
@b1ackviking
Copy link
Contributor Author

@david-cermak Happy to see that, thanks.

espressif-bot pushed a commit that referenced this pull request Apr 27, 2021
Implement the PHY and MAC layers in the driver similar to
the W5500 driver.

Update Kconfig, CMakeLists.txt, and component.mk to incorporate
the changes.

Resolves: #6542

Merges #6636
Closes #6542
@b1ackviking
Copy link
Contributor Author

@Alvin1Zhang @david-cermak Is it OK that the bot has committed the files instead of merging the branch? The linked issue is now closed, but the PR remains open.

@suda-morris
Copy link
Collaborator

The bot can't "merge" and "close" this PR because we have rebased your commit, so Github can't match your original commit anywhere. Will close this PR manually.

@b1ackviking
Copy link
Contributor Author

@suda-morris OK, thanks.

@b1ackviking b1ackviking deleted the feature/esp_eth_ksz8851snl branch April 28, 2021 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Done Issue is done internally Status: Done Issue is done internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add KSZ8851SNL Ethernet driver (IDFGH-4736)
6 participants