partition_table requires esptool_py for esptool_py_flash_target (IDFGH-4876) #6672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
changed the title
|
Thanks for your contribution. |
|
This is the right approach, thanks! MR will be updated when this merges. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
possible fix for #6670
Not sure if this is the right approach.
A sample project is attached and posted to the issue which shows the behavior. The project will trigger the issue without this fix. With this fix, the project will build (but will not compile, which is fine).
Including component app_update triggers the issue, but i believe that's due to alphabetical component building. The root cause appears to be partition_table doesn't explicitly require esptool_py.
simple.zip